This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] MIPS: Use `.set arch=mips2' to emulate LL/SC for the R5900 too
On Sat, 27 Oct 2018, Maciej W. Rozycki wrote:
> This change looks good if not obvious to me, however I think it would
> make sense if you mentioned in the change description why you actually
> need this to build for the R5900, i.e. quoted the lack of hardware LL/SC
> instructions in the R5900 despite it matching `__mips >= 2', the build
> errors you've still seen with `.set mips2', and the analysis of their
> cause we have made off-list (which would serve as an explanation of the
> difference between `.set mips2' and `.set arch=mips2', which is subtle
> enough for someone coming across this change to wonder).
I think an explanation of the need for the "|| defined(_MIPS_ARCH_R5900)"
(which is missing a space before the '(' as per GNU style) should go in a
comment in the source code, not just the commit message.
Joseph S. Myers