This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Ensure mktime sets errno on error (bug 23789)

From: Andreas Schwab <schwab at suse dot de>
To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
Cc: Zack Weinberg <zackw at panix dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 25 Oct 2018 09:42:50 +0200
Subject: Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
References: <20181024193206.22790-1-albert.aribaud@3adev.fr> <CAKCAbMi6kLbGOhcv_3yHmjL4+E6OjuH5nqQBVhSdcKjQFR8tRA@mail.gmail.com> <20181025063436.0c478732@athena>

On Okt 25 2018, Albert ARIBAUD <albert.aribaud@3adev.fr> wrote:

> The change is about errno, which is part of the public interface, so I
> considered it was more logical to put it in the wrapper which
> implements the public interface than in an internal function.

I think timegm should get the same treatment for consistency.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

References:
- [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD (3ADEV)
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Zack Weinberg
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]