This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc bug 23789 (was: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, <libc-alpha at sourceware dot org>
- Date: Wed, 24 Oct 2018 16:20:50 +0000
- Subject: Re: glibc bug 23789 (was: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t)
- References: <20181017093126.23422-1-albert.aribaud@3adev.fr> <9ce5d618-12cd-3dca-3e7f-1812cdd3a1ae@cs.ucla.edu> <20181024132318.52ba1647@athena> <20181024175930.7f27a568@athena>
On Wed, 24 Oct 2018, Albert ARIBAUD wrote:
> And one last question: should I not first commit the test (and with make
> check on a 32-bit architecture, show that it adds one FAIL) then commit
> the fix (and show with the same make check that the FAIL disappears)?
No, you should verify the FAIL with the fix not present, but the test is
best committed at the same time as a fix, to preserve bisectability.
--
Joseph S. Myers
joseph@codesourcery.com