This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
- From: Zong Li <zongbox at gmail dot com>
- To: fweimer at redhat dot com, joseph at codesourcery dot com
- Cc: Zong Li <zong at andestech dot com>, libc-alpha at sourceware dot org
- Date: Wed, 24 Oct 2018 21:09:58 +0800
- Subject: Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
- References: <1532081682-25895-1-git-send-email-zong@andestech.com> <87zhv362a0.fsf@oldenburg.str.redhat.com>
Florian Weimer <fweimer@redhat.com> 於 2018年10月24日 週三 下午6:56寫道：
>
> * Zong Li:
>
> > The Makefile variable name loses the file extension (.so). It causes
> > the linker option not applies to the corresponding file that it's
> > file name matchs with the variable without LDFLAGS- prefix.
> >
> > * elf/Makefile (LDFLAGS-tst-execstack-mod): Change variable name by
> > adding the file extension (.so).
>
> This looks okay to me. Can you commit this yourself, or do you need
> someone who commits it for you?
>
No, I can't commit it by myself.