This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t

* Albert ARIBAUD:

> Hi Paul,
>
> On Wed, 17 Oct 2018 18:44:05 -0700, Paul Eggert <eggert@cs.ucla.edu>
> wrote :
>
>> This patch looks OK to me, modulo the spelling fix.
>> 
>> In reviewing this patch I noticed a longstanding bug in mktime that 
>> hasn't been reported. I just now reported it here:
>> 
>> https://sourceware.org/bugzilla/show_bug.cgi?id=23789
>> 
>> Fixing that bug may affect the patch.
>
> Should I go and provide a fix to that bug, then, and resubmit my patch
> over the fix?

I do not have a strong preference here, as long as the bug fix goes into
a separate patch.

(Despite what I just told to H.J., I think in general we should not
force contributors to fix peripherally related bugs as part of the work
they set out to do.)

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]