This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 01/13] C-SKY: ABI related code
- From: "Richard W.M. Jones" <rjones at redhat dot com>
- To: Palmer Dabbelt <palmer at sifive dot com>
- Cc: fweimer at redhat dot com, merker at debian dot org, mafm at debian dot org, dj at redhat dot com, david dot abdurachmanov at gmail dot com, han_mao at c-sky dot com, "H.J. Lu" <hjl dot tools at gmail dot com>, c-sky_gcc_upstream at c-sky dot com, gnu-csky at mentor dot com, libc-alpha at sourceware dot org
- Date: Mon, 1 Oct 2018 09:14:01 +0100
- Subject: Re: [PATCH v4 01/13] C-SKY: ABI related code
- References: <0f0b5b18-056b-c622-e313-74bf714ecb2a@redhat.com> <mhng-13753add-0b55-4ee7-87e1-ce750c33c9db@palmer-si-x1c4>
On Fri, Sep 28, 2018 at 06:46:08PM -0700, Palmer Dabbelt wrote:
> On Wed, 12 Sep 2018 01:23:29 PDT (-0700), fweimer@redhat.com wrote:
> >On 09/12/2018 09:07 AM, Mao Han wrote:
> >>It seems used to call some pre-init function for libc, register transactional
> >>memory clone tables and invoke global constructors on C-SKY. Althrough I
> >>haven't found any constructors call by _init, I just tend to have _init and
> >>_fini as most other arch have these.
> >
> >The expectation is that for new glibc ports, GCC is tweaked to generate
> >the array variant of these constructs exclusively, like RISC-V did.
> >Then you won't need the function variant.
>
> I think we're the only ones who do it this way, but it appears to
> work and saves us a few symbols so I see no reason not to do so. In
> RISC-V land we're pretty aggressive about pruning old interfaces,
> but this one doesn't appear to have bitten us anywhere (or at least,
> has bitten us less than others :)).
>
> The distro guys are probably in a better place to comment on this
> decision, though, as this is one of those things that will only crop
> up in real code. I've added a few people who are more plugged in to
> these sorts of issues than I am.
I read the thread, which for reference starts here:
https://sourceware.org/ml/libc-alpha/2018-09/threads.html#00126
As mafm said too, we'd need to know what to look for to answer this
question. If you can suggest either a message that might have
appeared in the log files during compilation, or a test we can run
across all final binaries/libraries, then I'd be able to do that for
Fedora.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW