This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Add missing CFI register information [BZ #23614]
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 28 Sep 2018 16:00:43 -0300
- Subject: Re: [PATCH] powerpc: Add missing CFI register information [BZ #23614]
- References: <20180906214302.3158-1-tuliom@linux.ibm.com>
On Thu, 06 Sep 2018, Tulio Magno Quites Machado Filho wrote:
> [BZ #23614]
> * sysdeps/powerpc/powerpc64/addmul_1.S (FUNC): Add CFI offset for
> registers saved in the stack frame.
> * sysdeps/powerpc/powerpc64/lshift.S (__mpn_lshift): Likewise.
> * sysdeps/powerpc/powerpc64/mul_1.S (__mpn_mul_1): Likewise.
OK
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S (__brk): Likewise.
> (...)
>diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S
>index c8cb7edf77..fa769add4d 100644
>--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S
>+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S
>@@ -29,6 +29,7 @@ ENTRY (__brk)
> CALL_MCOUNT 1
>
> std r3,-8(r1)
>+ cfi_offset(r3, -8)
> DO_CALL(SYS_ify(brk))
> ld r6,-8(r1)
> ld r5,.LC__curbrk@toc(r2)
As mentioned in https://sourceware.org/bugzilla/show_bug.cgi?id=23614#c1,
this is not needed.
Looks good to me with this hunk removed and ChangeLog updated.
Reviewed-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>