This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Use _dl_runtime_[resolve|profile]_shstk for SHSTK [BZ #23716]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 26 Sep 2018 19:23:26 +0200
- Subject: Re: [PATCH] i386: Use _dl_runtime_[resolve|profile]_shstk for SHSTK [BZ #23716]
- References: <20180926171711.29435-1-hjl.tools@gmail.com>
* H. J. Lu:
> diff --git a/sysdeps/i386/dl-trampoline.S b/sysdeps/i386/dl-trampoline.S
> index 6dc0319216..9734f9c981 100644
> --- a/sysdeps/i386/dl-trampoline.S
> +++ b/sysdeps/i386/dl-trampoline.S
> @@ -33,6 +33,7 @@
> _dl_runtime_resolve:
> cfi_adjust_cfa_offset (8)
> _CET_ENDBR
> + hlt
> pushl %eax # Preserve registers otherwise clobbered.
> cfi_adjust_cfa_offset (4)
> pushl %ecx
That doesn't look right. 8-)
Florian