This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Complete sys/procfs.h unification
On 21/09/2018 16:40, Joseph Myers wrote:
> This patch, relative to a tree with
> <https://sourceware.org/ml/libc-alpha/2018-09/msg00216.html> and
> <https://sourceware.org/ml/libc-alpha/2018-09/msg00362.html> (both
> pending review) applied, completes the process of unifying
> sys/procfs.h headers for architectures using the Linux kernel by
> making alpha use the generic version.
>
> That was previously deferred because alpha has different definitions
> of prgregset_t and prfpregset_t from other architectures, so changing
> to the common definitions would change C++ name mangling. To avoid
> such a change, a header bits/procfs-prregset.h is added, and alpha
> gets its own version of that header.
>
> Tested for x86_64 and x86, and with build-many-glibcs.py.
Another possible way to increase coverage is to add static asserts with
expected struct size and members offset. It won't check the expected type
though, and it would require some more arch-specific code to add the
expected values.
>
> 2018-09-21 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/sys/procfs.h: Include
> <bits/procfs-prregset.h>.
> (prgregset_t): Define using __prgregset_t.
> (prfpregset_t): Define using __prfpregset_t.
> * sysdeps/unix/sysv/linux/Makefile [$(subdir) = misc]
> (sysdep_headers): Add bits/procfs-prregset.h.
> * sysdeps/unix/sysv/linux/bits/procfs-prregset.h: New file.
> * sysdeps/unix/sysv/linux/alpha/bits/procfs-prregset.h: Likewise.
> * sysdeps/unix/sysv/linux/alpha/bits/procfs.h: Likewise.
> * sysdeps/unix/sysv/linux/alpha/sys/procfs.h: Remove file.
LGTM, thanks.