This is the mail archive of the
mailing list for the glibc project.
PING^1: V2 [PATCH] Check multiple NT_GNU_PROPERTY_TYPE_0 notes [BZ #23509]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Wed, 19 Sep 2018 05:55:54 -0700
- Subject: PING^1: V2 [PATCH] Check multiple NT_GNU_PROPERTY_TYPE_0 notes [BZ #23509]
Carlos, can you take a look at this?
On Sun, Aug 26, 2018 at 7:52 AM, H.J. Lu <firstname.lastname@example.org> wrote:
> On Tue, Aug 14, 2018 at 10:32 AM, H.J. Lu <email@example.com> wrote:
>> The older linker treats .note.gnu.property section as a generic note
>> section and just concatenates all .note.gnu.property sections from the
>> inputs to the output. When the older linker is used to created the
>> program on CET-enabled OS, the generated output has .note.gnu.property
>> section with multiple NT_GNU_PROPERTY_TYPE_0 notes whose IBT and SHSTK
>> enable bits are set even if the program isn't CET enabled. Such program
>> will crash on CET-enabled machines. This patch updates the note parser:
>> 1. Skip note parsing if a NT_GNU_PROPERTY_TYPE_0 note has been processed.
>> 2. Check multiple NT_GNU_PROPERTY_TYPE_0 notes.
>> OK for master?
>> [BZ #23509]
>> * sysdeps/x86/dl-prop.h (_dl_process_cet_property_note): Skip
>> note parsing if a NT_GNU_PROPERTY_TYPE_0 note has been processed.
>> Update the l_cet field when processing NT_GNU_PROPERTY_TYPE_0 note.
>> Check multiple NT_GNU_PROPERTY_TYPE_0 notes.
>> * sysdeps/x86/link_map.h (l_cet): Expand to 3 bits, Add
> Here is the updated patch which passed CET smoke test: