This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Add new pow implementation

From: Joseph Myers <joseph at codesourcery dot com>
To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>, <nd at arm dot com>
Date: Mon, 17 Sep 2018 22:19:06 +0000
Subject: Re: [PATCH 3/3] Add new pow implementation
References: <391ac2f9-9ee4-ac23-b791-09f0438c2b91@arm.com> <da5d2b2e-6af2-206b-529a-a5f3b6ed0662@arm.com>

On Tue, 11 Sep 2018, Szabolcs Nagy wrote:

> +/* Returns 0 if not int, 1 if odd int, 2 if even int.  */
> +static inline int
> +checkint (uint64_t iy)

The comment needs to explain that this function is not called with an 
argument representing floating-point 0, Inf or NaN (since it wouldn't be 
correct for 0 at least).

OK with that change.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH 3/3] Add new pow implementation
  - From: Szabolcs Nagy

References:
- [PATCH 0/3] New log, log2 and pow
  - From: Szabolcs Nagy
- [PATCH 3/3] Add new pow implementation
  - From: Szabolcs Nagy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]