This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Update siginfo constants from Linux kernel (bug 21286)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 3 Sep 2018 15:31:51 +0000
- Subject: Re: Update siginfo constants from Linux kernel (bug 21286)
- References: <alpine.DEB.2.21.1808301557410.4027@digraph.polyomino.org.uk> <CAMe9rOo4WVe6peMR=jHCU3SvU-9ABWinskaybWsRzt492_WNyQ@mail.gmail.com> <alpine.DEB.2.21.1809031348110.9070@digraph.polyomino.org.uk> <CAMe9rOoyLEPU=X4rm_F_ov8E=oRecisZWvPhWTYXj7LVzvHLsg@mail.gmail.com>
On Mon, 3 Sep 2018, H.J. Lu wrote:
> >> Wasn't SI_DETHREAD there in 2012? Should it be a separate patch?
> >
> > The patch is generically making the header reflect the current set of
> > constants in the kernel, without regard to when the kernel added them in
> > what header.
>
> A separate patch for SI_DETHREAD is much easier to review. It
> may be useful for backport. Can you make a separate patch for
> SI_DETHREAD?
I don't see it as useful. It doesn't reflect the nature of the patch
(which was based on reviewing against Linux 4.18, not checking for each
constant when it was added to the kernel; I doubt that would be the only
split based on kernel versions).
--
Joseph S. Myers
joseph@codesourcery.com