This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Speedup tanf range reduction
Tulio Magno Quites Machado Filho wrote:
> LGTM too.
Thanks, I've committed it.
> If we were to have a benchtest for tanf with drand48 inputs, should we group
> the entries according to __kernel_tanf() ? e.g.
> * |x|>=0.6744 - fast path for __kernel_tanf
> * |x|<=0.6744
Having a real trace would be best, and randomized inputs for commonly used
input ranges are useful. I'm not sure whether a better algorithm would have the
same slow/fast paths as the current code (sinf/cosf are now 4x faster...), but
if you're planning to post a benchtest then testing those ranges would be fine.