This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc64: Remove support for !HAVE_INLINED_SYSCALLS
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Mon, 20 Aug 2018 13:29:59 -0300
- Subject: Re: [PATCH] powerpc64: Remove support for !HAVE_INLINED_SYSCALLS
- References: <20180820144034.B630C4028A147@oldenburg.str.redhat.com>
On 20/08/2018 11:40, Florian Weimer wrote:
> HAVE_INLINED_SYSCALLS is always defined on Linux.
>
> 2018-08-20 Florian Weimer <fweimer@redhat.com>
>
> * sysdeps/powerpc/powerpc64/dl-machine.h (DL_STARTING_UP_DEF):
> Remove macro.
> (RTLD_START): Adjust.
This file is not Linux specific, so it can potentially be used on a port
which defines HAVE_INLINED_SYSCALLS. Is the plan to get rid of
HAVE_INLINED_SYSCALLS altogether?
>
> diff --git a/sysdeps/powerpc/powerpc64/dl-machine.h b/sysdeps/powerpc/powerpc64/dl-machine.h
> index 99a83d0c82..a768a08cd7 100644
> --- a/sysdeps/powerpc/powerpc64/dl-machine.h
> +++ b/sysdeps/powerpc/powerpc64/dl-machine.h
> @@ -122,16 +122,6 @@ elf_machine_dynamic (void)
> #define elf_machine_relplt elf_machine_rela
>
>
> -#ifdef HAVE_INLINED_SYSCALLS
> -/* We do not need _dl_starting_up. */
> -# define DL_STARTING_UP_DEF
> -#else
> -# define DL_STARTING_UP_DEF \
> -".LC__dl_starting_up:\n" \
> -" .tc __GI__dl_starting_up[TC],__GI__dl_starting_up\n"
> -#endif
> -
> -
> /* Initial entry point code for the dynamic linker. The C function
> `_dl_start' is the real entry point; its return value is the user
> program's entry point. */
> @@ -165,7 +155,6 @@ BODY_PREFIX "_start:\n" \
> " .align 2\n" \
> " " END_2(_start) "\n" \
> " .pushsection \".toc\",\"aw\"\n" \
> -DL_STARTING_UP_DEF \
> ".LC__rtld_local:\n" \
> " .tc _rtld_local[TC],_rtld_local\n" \
> ".LC__dl_argc:\n" \
>