This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Makeconfig: Do not sort and deduplicate +cflags [BZ # 17248]
- From: fweimer at redhat dot com (Florian Weimer)
- To: libc-alpha at sourceware dot org
- Date: Fri, 17 Aug 2018 15:24:01 +0200
- Subject: [PATCH] Makeconfig: Do not sort and deduplicate +cflags [BZ # 17248]
The original intent behind this is unclear. It interferes with flags
that has to be ordered in a particular way.
This change does not introduce any changes in the built binaries on
x86-64, and build-many-glibcs.py shows no regressions, either. (I did
not compare all object files, though.)
2018-08-17 Florian Weimer <fweimer@redhat.com>
[BZ #17248]
* Makeconfig (+cflags): Do not sort (and deduplicate).
diff --git a/Makeconfig b/Makeconfig
index 92e76d6200..a9e50e5b60 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -902,9 +902,6 @@ endif # $(+cflags) == ""
$(+stack-protector)
+gcc-nowarn := -w
-# Don't duplicate options if we inherited variables from the parent.
-+cflags := $(sort $(+cflags))
-
# Each sysdeps directory can contain header files that both will be
# used to compile and will be installed. Each can also contain an
# include/ subdirectory, whose header files will be used to compile