This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nscd: Deallocate existing user names in file parser


Florian Weimer <fw@deneb.enyo.de> writes:
>> Note that free() nominally takes a void*, not a char*.  I think we
>> should use void* in this case.
>
> My idea was to make clear that I'm casting away const here (similar to
> C++'s const_cast).

Two comments then:

1. A suitable comment would have make it clearer :-)

2. Why are those variables const in the first place?  They're only ever
   assigned values from xstrdup(), which isn't const.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]