Re: [PATCH] Reduce the statically linked startup code [BZ #23323]

[Florian Weimer <fweimer at redhat dot com>]

On 08/08/2018 05:10 PM, H.J. Lu wrote:
> On Wed, Aug 8, 2018 at 7:48 AM, Florian Weimer <fweimer@redhat.com> wrote:
> > This is the patch rebased for glibc 2.29.
> >
> > Should we make more far-reaching changes and remove the arguments which are
> > now zero?
>
> i386 and x86-64 parts look good, except for
>
> + /* These used to be the addresses of .fini and .init.  */
> + xor %R8_LP, %R8_LP
> + xor %RCX_LP, %RCX_LP
>
> Please use
>
> xorl %r8d, %r8d
> xorl %ecx, %ecx
>
> They will zero-extend to 64 bits.

Thanks, I've made the change locally.  xorl %ecx, %ecx is indeed one 
byte shorter.

Florian