This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv5] Add convenience target 'install-locale-files'.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Rical Jasan <rj at 2c3t dot io>, GNU C Library <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Thu, 2 Aug 2018 15:32:57 -0400
- Subject: Re: [PATCHv5] Add convenience target 'install-locale-files'.
- References: <7b4c3d0d-3fa1-3302-5e09-84326cb279d1@redhat.com> <alpine.DEB.2.20.1807261732550.25831@digraph.polyomino.org.uk> <3d01061c-9323-09ab-8571-75900dabd397@redhat.com> <aefb9a47-f634-6df4-0d80-8e980132b8d2@2c3t.io> <7e678d8f-0b90-475a-feec-7e0d54127f62@redhat.com> <alpine.DEB.2.20.1807262024040.6526@digraph.polyomino.org.uk> <e79af0cb-7419-fe7c-fd74-f6b46dd3e113@redhat.com> <85bae216-5769-272b-6135-779000527a10@redhat.com>
On 07/27/2018 04:17 PM, Carlos O'Donell wrote:
> On 07/26/2018 04:30 PM, Carlos O'Donell wrote:
>> On 07/26/2018 04:25 PM, Joseph Myers wrote:
>>> On Thu, 26 Jul 2018, Carlos O'Donell wrote:
>>>
>>>> +directories e.g. @file{/usr/lib/locale/en_US.utf8}. For example to install
>>>
>>> Should have exactly one space after "e.g.", and need @: before that space
>>> for it to be properly treated as not an end-of-sentence space.
>>>
>>>> +root use @samp{DESTDIR} e.g. @samp{make localedata/install-locale-files
>>>
>>> Likewise, need @: after e.g. to avoid makeinfo treating it as the end of a
>>> sentence and inserting an extra space in INSTALL there.
>>>
>>
>> Thanks! I'd forgotten about that.
>>
>> v4
>> - Fix texinfo formatting.
>
> v5
> - Fix commit message to use DESTDIR.
>
> Final version. I'll push this when 2.29 opens if nobody objects.
Committed.
--
Cheers,
Carlos.