This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] SH: statx is missing in the kernel
- From: Christoph Hellwig <hch at lst dot de>
- To: Yoshinori Sato <ysato at users dot sourceforge dot jp>, Rich Felker <dalias at libc dot org>, linux-sh at vger dot kernel dot org
- Cc: Florian Weimer <fweimer at redhat dot com>, Carlos O'Donell <codonell at redhat dot com>, Romain Naour <romain dot naour at gmail dot com>, libc-alpha at sourceware dot org
- Date: Mon, 30 Jul 2018 13:24:59 +0200
- Subject: Re: [PATCH] SH: statx is missing in the kernel
- References: <20180723180545.23274-1-romain.naour@gmail.com> <5f14ef2c-3b6e-7a97-3927-939566b53629@redhat.com>
Dear linux-sh maintainers,
can we make sure to at least wire statx for 4.19? That's not going
to immediately solve the glibc problem, but at least it won't be
prolonged.
On Tue, Jul 24, 2018 at 08:51:25PM +0200, Florian Weimer wrote:
> On 07/23/2018 08:05 PM, Romain Naour wrote:
>> __NR_statx is not defined by the kernel headers and __ASSUME_STATX is
>> defined since kernel 4.11.
>>
>> __ASSUME_STATX must be undefined until SH kernel support statx.
>
> Carlos, I would like to check in the attached patch for 2.28. I
> compile-tested this with build-many-glibcs.py against a 4.11 kernel tree
> with --enable-kernel=4.13.
>
> I'm preparing another patch for alpha, which still has to undergo testing
> on kernel 4.13 sources.
>
> Thanks,
> Florian
> Subject: [PATCH] sh: Do not define __ASSUME_STATX
> To: libc-alpha@sourceware.org
>
> 2018-07-24 Florian Weimer <fweimer@redhat.com>
>
> * sysdeps/unix/sysv/linux/sh/kernel-features.h (__ASSUME_STATX):
> Undefine. Suggested by Romain Naour <romain.naour@gmail.com>.
>
> diff --git a/sysdeps/unix/sysv/linux/sh/kernel-features.h b/sysdeps/unix/sysv/linux/sh/kernel-features.h
> index 05b7dcd037..b8ccb01518 100644
> --- a/sysdeps/unix/sysv/linux/sh/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/sh/kernel-features.h
> @@ -56,4 +56,7 @@
> # undef __ASSUME_RENAMEAT2
> #endif
>
> +/* sh does not support the statx system call. */
> +#undef __ASSUME_STATX
> +
> #endif
---end quoted text---