This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] soft-fp: Add the lack of implementation for 128 bit self-contained.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zong Li <zong at andestech dot com>
- Cc: <palmer at dabbelt dot com>, <darius at bluespec dot com>, <andrew at sifive dot com>, <dj at redhat dot com>, <libc-alpha at sourceware dot org>, <rth7680 at gmail dot com>, <zongbox at gmail dot com>
- Date: Thu, 26 Jul 2018 12:03:02 +0000
- Subject: Re: [PATCH v2] soft-fp: Add the lack of implementation for 128 bit self-contained.
- References: <1532581161-6380-1-git-send-email-zong@andestech.com>
On Thu, 26 Jul 2018, Zong Li wrote:
> + fa8_c = (fa8_c ? \
> + R##_f[fa8_i] <= X##_f[fa8_i] : \
> + R##_f[fa8_i] < X##_f[fa8_i]); \
GNU formatting breaks lines before operators, not after, so ? and : at
start not end of lines.
> + fs8_c = (fs8_c ? \
> + R##_f[fs8_i] >= X##_f[fs8_i] : \
> + R##_f[fs8_i] > X##_f[fs8_i]); \
Likewise.
> + (R) += _FP_W_TYPE_SIZE*2; \
GNU formatting uses spaces around binary operators such as *.
> +#define _FP_FRAC_ZEROP_8(X) \
> + ((X##_f[0] | X##_f[1] | X##_f[2] | X##_f[3] | \
> + X##_f[4] | X##_f[5] | X##_f[6] | X##_f[7]) == 0)
Again, break lines before not after operators, so | at start of line.
--
Joseph S. Myers
joseph@codesourcery.com