This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix C11 conformance issues
On Wed, 25 Jul 2018, Adhemerval Zanella wrote:
> The patch below should fix it and the hurd specific stdc-predef.h with
> __STDC_NO_THREADS__ defined. I would like to avoid duplicating a file
> contents, but the other possible alternative which I can think of would
> add a platform specific file (empty for nptl case and defining
> __STDC_NO_THREADS__ for htl) with the drawback of adding another
> include on every compilation (due extra include). I think we can
> live with a hurd specific stdc-predef.h for now.
This patch is OK. The handling of precompiled headers in GCC is very
fragile with regard to implicitly preincluded files and if stdc-predef.h
were to include another header, there would be a significant chance of
this breaking PCH.
--
Joseph S. Myers
joseph@codesourcery.com