This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Fix C11 conformance issues
On Wed, 25 Jul 2018, Florian Weimer wrote:
> On 07/25/2018 07:18 PM, Joseph Myers wrote:
> > On Wed, 25 Jul 2018, Florian Weimer wrote:
> > > On 07/25/2018 03:43 PM, Adhemerval Zanella wrote:
> > > > linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
> > > > - $(common-objpfx)nptl/libpthread.a
> > > > -linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
> > > > - $(common-objpfx)crypt/libcrypt.a
> > > > + $(static-thread-library)
> > >
> > > I've just realized this:
> > >
> > > Linking with the static thread library obscures linknamespace issues in
> > > libc.a
> > > for symbols which are also defined in libpthread.a. So this change is a
> > > bit
> > > questionable.
> > The linknamespace code looks at every definition of a strong undefined
> > symbol being resolved, not just the definition in a particular library.
> So there is not a problem after all?
I don't think there's any problem with that part of the patch.
> What seems to be a problem is that libpthread.a must now be C11-clean for its
> C11 symbols (which is currently not the case on Hurd). But fixing that is
> probably not a bad idea anyway.
Yes, if libpthread is used to provide some C11 symbols, it needs to be
C11-clean for all the C11 symbols it provides (including those also
present in libc).
Joseph S. Myers