This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix out-of-bounds access in IBM-1360 converter
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>, libc-alpha <libc-alpha at sourceware dot org>
- Cc: Jeff Law <law at redhat dot com>, Martin Sebor <msebor at gmail dot com>
- Date: Tue, 24 Jul 2018 11:50:36 -0400
- Subject: Re: [PATCH] Fix out-of-bounds access in IBM-1360 converter
- References: <4012c914-e051-3f6c-f604-555de0db8c69@redhat.com> <mvmlga022dh.fsf@suse.de>
On 07/24/2018 09:24 AM, Andreas Schwab wrote:
> The IBM-1360 converter can consume/produce two UCS4 characters in each
> loop.
>
> * iconvdata/ibm1364.c (MAX_NEEDED_OUTPUT) [FROM_LOOP]: Define.
> (MAX_NEEDED_INPUT) [TO_LOOP]: Define.
Confirmed. In both ibm1390 and ibm1399 we have combining characters
which are two UCS4 characters, and in that case we need 8 bytes in
the output.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> iconvdata/ibm1364.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/iconvdata/ibm1364.c b/iconvdata/ibm1364.c
> index b833273aa8..517fe60813 100644
> --- a/iconvdata/ibm1364.c
> +++ b/iconvdata/ibm1364.c
> @@ -150,6 +150,7 @@ enum
> #define MIN_NEEDED_INPUT MIN_NEEDED_FROM
> #define MAX_NEEDED_INPUT MAX_NEEDED_FROM
> #define MIN_NEEDED_OUTPUT MIN_NEEDED_TO
> +#define MAX_NEEDED_OUTPUT MAX_NEEDED_TO
> #define LOOPFCT FROM_LOOP
> #define BODY \
> { \
> @@ -296,6 +297,7 @@ enum
>
> /* Next, define the other direction. */
> #define MIN_NEEDED_INPUT MIN_NEEDED_TO
> +#define MAX_NEEDED_INPUT MAX_NEEDED_TO
> #define MIN_NEEDED_OUTPUT MIN_NEEDED_FROM
> #define MAX_NEEDED_OUTPUT MAX_NEEDED_FROM
> #define LOOPFCT TO_LOOP
>