This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v6 1/2] Y2038: Add 64-bit time for all architectures

On Fri, 6 Jul 2018, Albert ARIBAUD (3ADEV) wrote:

>  bits/timesize.h                              | 23 +++++++++++
>  bits/timesizes.h                             | 37 ++++++++++++++++++

The names of these headers are much too similar, and thus too confusing.  
(I think it's bits/timesizes.h that should be renamed, as the header has 
nothing to do with defining sizes of types.)

As previously noted, I consider these changes inappropriate for during the 
freeze; early in a release cycle is a much more suitable time.

> diff --git a/bits/timesize.h b/bits/timesize.h
> new file mode 100644
> index 0000000000..0739a34df4
> --- /dev/null
> +++ b/bits/timesize.h
> @@ -0,0 +1,23 @@
> +/* Bit size of the time_t type at glibc build time, general case.
> +   Copyright (C) 2018 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +   Contributed by Ulrich Drepper <>, 2002.

No "Contributed by" in new files.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]