This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] io: Avoid running some tests if the file system does not support holes

From: Florian Weimer <fw at deneb dot enyo dot de>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Fri, 13 Jul 2018 21:44:33 +0200
Subject: Re: [PATCH] io: Avoid running some tests if the file system does not support holes
References: <20180713121033.7626643994575@oldenburg.str.redhat.com> <d3eeba56-acce-e5ab-7b50-644a7ccc65e0@linaro.org>

* Adhemerval Zanella:

>> +      /* Our write may add this number of additional blocks.  */
>> +      block_headroom = 8,
>
> Is this number based on 512 physical block size with a 4kb page size?
> If so, shouldn't we try to determine this at runtime?

It's just an arbitrary number in case the file system needs blocks to
store large holes or something like that.  I can make the number 11 to
make this more obvious, and expand the comment.

timezone/tst-tzset.c needs a similar check, so I have to send a new
patch anyway.

References:
- [PATCH] io: Avoid running some tests if the file system does not support holes
  - From: Florian Weimer
- Re: [PATCH] io: Avoid running some tests if the file system does not support holes
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]