This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] New language: Lower Sorbian (dsb_DE) [BZ #23208]
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: libc-alpha at sourceware dot org, Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- Date: Wed, 11 Jul 2018 23:56:33 +0200 (CEST)
- Subject: Re: [PATCH v3] New language: Lower Sorbian (dsb_DE) [BZ #23208]
- References: <744203676.887878.1529363268253@poczta.nazwa.pl> <1382833401.420415.1529365499080@poczta.nazwa.pl> <1692783399.1120662.1530181968375@poczta.nazwa.pl> <821544930.515408.1530182363235@poczta.nazwa.pl> <alpine.DEB.2.20.1806281553020.16299@digraph.polyomino.org.uk> <716008909.1183425.1530261584908@poczta.nazwa.pl> <1443057971.1161272.1530307501883@poczta.nazwa.pl> <87sh4qssxg.fsf@linux.ibm.com> <726305023.15722.1531266737048@poczta.nazwa.pl> <87pnzurksp.fsf@linux.ibm.com>
- Reply-to: Rafal Luzynski <digitalfreak at lingonborough dot com>
11.07.2018 14:58 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> wrote:
>
> Rafal Luzynski <digitalfreak@lingonborough.com> writes:
>
> > 10.07.2018 23:05 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> > wrote:
> >> [...]
> >> Anyone else seeing the following errors when installing this locale?
> >>
> >> locales/dsb_DE:80: LC_COLLATE: syntax error
> >> locales/dsb_DE:81: LC_COLLATE: syntax error
> >
> > I can't see. Do you mean "make install" or installing a binary, like
> > "dnf update glibc" or "dnf install glibc-langpack-dsb"? If a binary,
> > what distro is this?
>
> It's a make command, but not just "make install":
> https://sourceware.org/glibc/wiki/Locales#Testing_Locales
>
> More like:
> make localedata/install-locales install_root=(configure's --prefix)
OK, it is also visible in glibc build logs in koji.fedoraproject.org.
However, this error is ignored by scripts and binaries ar generated and
there are no further error messages.
Indeed, there is a syntax error. Thank you for spotting it! I have fixed
this and added a test to make sure this bug is spotted earlier in case of
a regression.
OK to commit to master? As we are in the slushy freeze period I will not
commit without a review.
(The patch follows in the next message)
Regards,
Rafal