This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add the statx function

From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
To: Florian Weimer <fweimer at redhat dot com>, Andreas Schwab <schwab at suse dot de>
Cc: nd at arm dot com, Carlos O'Donell <carlos at redhat dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org
Date: Wed, 11 Jul 2018 11:01:41 +0100
Subject: Re: [PATCH] Add the statx function
References: <20180630224103.4501543994575@oldenburg.str.redhat.com> <4934579e-a05c-3dcc-0b26-5ec09e03fbb3@cs.ucla.edu> <b1fd37e8-4fc5-9335-ab30-3685ab78be1f@redhat.com> <bf23d039-5001-e40c-3a7c-735b597ae106@cs.ucla.edu> <39950c72-09e7-4557-d62f-4b3a65ec5353@redhat.com> <9378e999-9c2b-0925-89e0-d9c39101b1bf@redhat.com> <85b41fe2-05f1-094d-c9c2-f3149e4dce83@redhat.com> <mvmh8l65klp.fsf@suse.de> <cf125b99-d485-5b37-b01f-cd5a923d3b89@redhat.com>

On 11/07/18 07:55, Florian Weimer wrote:

On 07/11/2018 08:53 AM, Andreas Schwab wrote:

/usr/include/sys/stat.h:446:11: fatal error: bits/statx.h: No such file or directory
  # include <bits/statx.h>
            ^~~~~~~~~~~~~~


Okay, so this file should be an installed header.  I will commit a fix after testing.

Any idea why our header tests do not catch this?


because the glibc source tree does have bits/statx.h
and all tests (incorrectly) run with internal headers
in the include path (not just the installed ones).

build-many-glibcs.py catches it though when building gcc
(i've just run into this).

Follow-Ups:
- Re: [PATCH] Add the statx function
  - From: Jeff Law
- Re: [PATCH] Add the statx function
  - From: Florian Weimer

References:
- Re: [PATCH] Add the statx function
  - From: Paul Eggert
- Re: [PATCH] Add the statx function
  - From: Florian Weimer
- Re: [PATCH] Add the statx function
  - From: Paul Eggert
- Re: [PATCH] Add the statx function
  - From: Florian Weimer
- Re: [PATCH] Add the statx function
  - From: Carlos O'Donell
- Re: [PATCH] Add the statx function
  - From: Florian Weimer
- Re: [PATCH] Add the statx function
  - From: Andreas Schwab
- Re: [PATCH] Add the statx function
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]