This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] regexec: Fix off-by-one bug in weight comparison [BZ #23036]



On 09/07/2018 15:00, Carlos O'Donell wrote:
> On 07/09/2018 01:20 PM, Florian Weimer wrote:
>> 2018-07-09  Florian Weimer  <fweimer@redhat.com>
>>
>> 	[BZ #23036]
>> 	* posix/regexec.c (check_node_accept_bytes): When comparing
>> 	weights, do not compare an extra byte after the end of the
>> 	weights.
> 
> I assume that this fixes the issue and that you have minimally passed
> the regression testing for x86_64. I would like a test for this, but it
> can wait. This regression is a blocker for the release, and I appreciate
> your root cause analysis of the issue.

I still think we should add a regression test for it, the bug report
have one quite simple which we can add as an independent test (which
should not invalidate testsuite validation already done).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]