This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 06/24] x86-64: Add _CET_ENDBR to STRCMP_SSE42
- From: Carlos O'Donell <carlos at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Fri, 6 Jul 2018 10:50:14 -0400
- Subject: Re: [PATCH 06/24] x86-64: Add _CET_ENDBR to STRCMP_SSE42
- References: <20180613153207.57232-1-hjl.tools@gmail.com> <20180613153207.57232-7-hjl.tools@gmail.com>
On 06/13/2018 11:31 AM, H.J. Lu wrote:
> Add _CET_ENDBR to STRCMP_SSE42, which is called indirectly, to support
> IBT.
>
> * sysdeps/x86_64/multiarch/strcmp-sse42.S (STRCMP_SSE42): Add
> _CET_ENDBR.
Please commit.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/x86_64/multiarch/strcmp-sse42.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-sse42.S b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> index 6fa0c2c7d2..5a0c6668a7 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-sse42.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-sse42.S
> @@ -126,6 +126,7 @@ END (GLABEL(__strncasecmp))
>
> STRCMP_SSE42:
> cfi_startproc
> + _CET_ENDBR
> CALL_MCOUNT
>
> /*
>
--
Cheers,
Carlos.