This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] locale: XFAIL newlocale usage in static binary (Bug 23164)

4.07.2018 21:35 Carlos O'Donell <> wrote:
> On 05/23/2018 07:55 PM, Rafal Luzynski wrote:
> > This is a very incomplete review. So far I can only confirm that your
> > patch compiles and adds one more XFAIL to the test results.
> Thanks for that review.
> I've committed what I posted.

Thank you, good to see this commit pushed.  Shouldn't you close the
bug report as well, and mark the Target Milestone 2.28?

> Comments follow.
> > 21.05.2018 20:14 Carlos O'Donell <> wrote:
> >>
> >> [...] In addition we add CURRENCY_SYMBOL test coverage
> >> which was the original problem reported in the related gcc/C++ PR.
> >
> > Would you please mention it in the commit message?
> I tried to keep the commit message simple.

I like what you have put in the ChangeLog and I thought that every
commit message should contain the ChangeLog entry copied.  Of course
it was correct to remove ChangeLog diff in libc-alpha post.  Never mind,
maybe I'm wrong and even if not it is probably impossible to fix the
commit comment now.

> To meet your requirement I have added the gcc/C++ PR linked into
> bug 23164 e.g.
> This way the bugzilla can be kept up to date with all the linked-in
> bugs from gcc/C++ PR that relate to this issue.

That's more than I expected but great, thank you.

[ cut the part where I just totally agree ]

> [...]
> In the future may I ask that you TO me directly on a review.
> It's hard for me to filter reviews of my patches that only respond to
> the list?

That's what I usually do.  Didn't I this time?  I'm sorry about that.
I don't understand why I did not, most probably my mistake.  If I had
any good reason then I don't remember it now, it's been a while ago.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]