This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] testrun.sh: Implement --tool=strace, --tool=valgrind
- From: Florian Weimer <fweimer at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 4 Jul 2018 13:32:04 +0200
- Subject: Re: [PATCH] testrun.sh: Implement --tool=strace, --tool=valgrind
- References: <20180630133359.B152643994575@oldenburg.str.redhat.com> <alpine.DEB.email@example.com>
On 06/30/2018 10:23 PM, Joseph Myers wrote:
On Sat, 30 Jun 2018, Florian Weimer wrote:
$(file …) appears to be the only convenient way to create files
with newlines and make substitution variables. This needs make 4.0
(released in 2013), so update the requirement to match.
An increase in make version required needs an entry in the "Changes to
build and runtime requirements" section of NEWS for the release with the
Okay. But first, we need to decide if we want this change, and if it is
sufficient justification to bump the make requirement (although newer
GNU make is also quite a bit faster at building glibc, it seems).
$(file …) could also be used to avoid passing down parameters to shell
scripts in various tests, I expected. The shell scripts themselves
could be generated from makefile fragments instead, or a file which
could be sourced by them. This would avoid the confusion positional
parameter refers to which makefile variable in the shell script.