This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC PATCH v3 01/12] C-SKY: ABI related code
- From: Mao Han <han_mao at c-sky dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: c-sky_gcc_upstream at c-sky dot com, gnu-csky at mentor dot com, libc-alpha at sourceware dot org
- Date: Tue, 3 Jul 2018 16:03:45 +0800
- Subject: Re: [RFC PATCH v3 01/12] C-SKY: ABI related code
- References: <cover.1530246556.git.han_mao@c-sky.com> <1c2031c79377fb4edbb68a813cd27846534fa98a.1530246556.git.han_mao@c-sky.com> <alpine.DEB.2.20.1806291636530.24607@digraph.polyomino.org.uk>
On Fri, Jun 29, 2018 at 04:40:10PM +0000, Joseph Myers wrote:
> On Fri, 29 Jun 2018, Mao Han wrote:
>
> > Codes in this patch contains lots of C-SKY ABI related code. They are written
> > accroding to the registers assgnments, relocations, assemblly described
> > in C-SKY CPU ABI Standards and C-SKY CPU manual.
>
> Could you include direct URLs to PDFs of these manuals in the introduction
> to future versions of the patch series (like you gave URLs for your GCC /
> binutils / Linux git repositories)?
>
We currently don't have any technical document put on the internet. I've
asked our toolchain principal to release some. Hopefully they will be
available next time.
> Preprocessor indentation, "# error" inside #if.
>
> > +#else
> > +# define CSKY_ABIV2
> > +#endif
>
> Why do you need this macro rather than just using the predefined
> __CSKYABIV2__ anywhere needing an ABI conditional? (Right now, of course,
> any such ABI conditionals will just have #error for the ABIv1 case, like
> the one here.)
It is some legacy code from our first port on 2013. I don't what it is
used for. I think I'll just remove it.
Best Regards,
Mao Han