This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] malloc: Remove malloc hooks (Bug 23328)
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: DJ Delorie <dj at redhat dot com>, Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Mon, 02 Jul 2018 16:16:47 +0200
- Subject: Re: [PATCH v2] malloc: Remove malloc hooks (Bug 23328)
- References: <ddf39fca-aa0a-9b14-ee78-a1bfa1225623@redhat.com>
* Carlos O'Donell:
> diff --git a/catgets/Makefile b/catgets/Makefile
> index 36f6a226c3..941e5cb4ea 100644
> --- a/catgets/Makefile
> +++ b/catgets/Makefile
> @@ -56,7 +56,8 @@ generated += tst-catgets.mtrace tst-catgets-mem.out
>
> generated-dirs += de
>
> -tst-catgets-ENV = NLSPATH="$(objpfx)%l/%N.cat" LANG=de MALLOC_TRACE=$(objpfx)tst-catgets.mtrace
> +tst-catgets-ENV = NLSPATH="$(objpfx)%l/%N.cat" LANG=de MALLOC_TRACE=$(objpfx)tst-catgets.mtrace \
> + LD_PRELOAD=$(objpfx)../malloc/libmalloc-extras.so
Should this be $(objpfx-common)malloc/libmalloc-extras.so instead?
Anyway, you should add a dependency on libmalloc-extras.so to
tst-catgets.out, or perhaps even link tst-catgets against
libmalloc-extras.so, so that the test is rerun once the DSO changes.
(This applies to other uses of mtrace, of course.)