This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFC V2 [2/2] test-in-container
- From: DJ Delorie <dj at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 28 Jun 2018 17:05:02 -0400
- Subject: Re: RFC V2 [2/2] test-in-container
> I like this interface for writing tests, but it doesn't quite work at
> present: the makefile doesn't know about the test dependency on
> libnss_test1.so.2 and libnss_test2.so.2, so you get spurious failures
> at high concurrency levels.
This is supposed to handle it, in nss/Makefile already:
$(patsubst %,$(objpfx)%.out,$(tests)) : \
$(objpfx)/libnss_test1.so$(libnss_test1.so-version) \
$(objpfx)/libnss_test2.so$(libnss_test2.so-version)
> Should these instructions be included in the makefile instead?
Well, two reasons not to...
1. There are a lot of shortcuts in that "syntax" that would be more
complex in a plain Makefile. Reducing the cost of adding lots of
tests was one of the design considerations.
2. We run that script after we've locked and cleaned the testroot, which
we can't do in the Makefile.