This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH1/2] Improve performance of sincosf
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Thu, 28 Jun 2018 17:24:18 +0000
- Subject: Re: [PATCH1/2] Improve performance of sincosf
- References: <DB5PR08MB10301908C58D8A9DD1C847BA83490@DB5PR08MB1030.eurprd08.prod.outlook.com>
On Tue, 26 Jun 2018, Wilco Dijkstra wrote:
> +/* New sincosf. */
Comments describing something as new are never appropriate; they'll
always become out of date.
> +extern sincos_t sincosf_table[2] attribute_hidden;
I'd expect this array, and thus all pointers to it, to be const; any
writable static / global data is suspect without a clear requirement for
it to be writable.
--
Joseph S. Myers
joseph@codesourcery.com