This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED] Fix documentation build with old makeinfo
On 28/06/2018 09:39, Szabolcs Nagy wrote:
> On 20/06/18 22:43, Adhemerval Zanella wrote:
>> diff --git a/manual/llio.texi b/manual/llio.texi
>> index 82f03be..e840c55 100644
>> --- a/manual/llio.texi
>> +++ b/manual/llio.texi
>> @@ -3281,12 +3281,13 @@ Set process or process group ID to receive @code{SIGIO} signals.
>> @xref{Interrupt Input}.
>> @end vtable
>> -This function is a cancellation point in multi-threaded programs. This
>> -is a problem if the thread allocates some resources (like memory, file
>> -descriptors, semaphores or whatever) at the time @code{fcntl} is
>> -called. If the thread gets canceled these resources stay allocated
>> -until the program ends. To avoid this calls to @code{fcntl} should be
>> -protected using cancellation handlers.
>> +This function is a cancellation point in multi-threaded programs for the
>> +commands @code{F_SETLKW} (and the LFS analogous @code{F_SETLKW64}) and
>> +@code {F_OFD_SETLKW}. This is a problem if the thread allocates some
>
> this broke the build for me on systems with old makeinfo.
> committed the patch below as obvious.
>
> With old makeinfo '@code {' fails because of the extra space.
>
> 2018-06-28 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * manual/llio.texi: Remove spurious space.
Thanks for catching it.
>
> diff --git a/manual/llio.texi b/manual/llio.texi
> index e840c55f86..2733b9cb73 100644
> --- a/manual/llio.texi
> +++ b/manual/llio.texi
> @@ -3283,7 +3283,7 @@ Set process or process group ID to receive @code{SIGIO} signals.
>
> This function is a cancellation point in multi-threaded programs for the
> commands @code{F_SETLKW} (and the LFS analogous @code{F_SETLKW64}) and
> -@code {F_OFD_SETLKW}. This is a problem if the thread allocates some
> +@code{F_OFD_SETLKW}. This is a problem if the thread allocates some
> resources (like memory, file descriptors, semaphores or whatever) at the time
> @code{fcntl} is called. If the thread gets canceled these resources stay
> allocated until the program ends. To avoid this calls to @code{fcntl} should