This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] gethostid (Linux variant): Switch to struct scratch_buffer [BZ #18023]
- From: DJ Delorie <dj at redhat dot com>
- To: fweimer at redhat dot com (Florian Weimer)
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 26 Jun 2018 14:16:09 -0400
- Subject: Re: [PATCH] gethostid (Linux variant): Switch to struct scratch_buffer [BZ #18023]
fweimer@redhat.com (Florian Weimer) writes:
> [BZ #18023]
> * sysdeps/unix/sysv/linux/gethostid.c (gethostid): Use struct
> scratch_buffer instead of extend_alloca. Update comments.
LGTM
A question about style, though... you have an if/else inside an else{}
block. Would it be more readable to do if {} elseif {} else {} instead?