This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings.

From: Florian Weimer <fweimer at redhat dot com>
To: Patsy Franklin <pfrankli at redhat dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 25 Jun 2018 19:18:41 +0200
Subject: Re: [PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings.
References: <CAOraFgDEbbq06LuN-RpB4K1WrCXiarWRHqTfVRYp-83WZFJfmQ@mail.gmail.com> <9b8c0727-f285-d779-27fc-7af294e44e45@redhat.com> <CAOraFgBcLLJFmTex_sV5BR+xCXzSLrtS6yzin2qQFth73x8tzQ@mail.gmail.com>

On 06/25/2018 07:15 PM, Patsy Franklin wrote:

Hi Florian,

On Mon, Jun 25, 2018 at 10:39 AM, Florian Weimer <fweimer@redhat.com> wrote:

On 06/25/2018 04:18 PM, Patsy Franklin wrote:


Prior to this change, valgrind warned about unitialized bytes on
ppc64, ppc64le, s390x, and aarch64.



How come that valgrind warns when it's supposed to be uninitialized padding?


The problem occurs when the partially initialized struct is written to
the file system.

I should have stated this in the original description.


Looks okay to me if you put this into the commit message.

Thanks,
Florian

References:
- [PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings.
  - From: Patsy Franklin
- Re: [PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings.
  - From: Florian Weimer
- Re: [PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings.
  - From: Patsy Franklin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]