Re: [PATCH 4/4] New configure option --disable-crypt.

[Florian Weimer <fweimer at redhat dot com>]

On 05/22/2018 12:34 AM, Joseph Myers wrote:
> On Mon, 21 May 2018, Zack Weinberg wrote:
>
> > On Mon, May 21, 2018 at 3:51 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> > > On Mon, 21 May 2018, Zack Weinberg wrote:
> > >
> > > > unistd.h continues to define _XOPEN_CRYPT to 1 and to declare crypt.
> > >
> > > I'd expect _XOPEN_CRYPT to change in patch 1, since it includes encrypt
> > > and setkey.
> >
> > No, this is an intentional deviation from the present state of POSIX,
> > anticipating the removal of those functions from the standard.
>
> That would only seem relevant to the _XOPEN_CRYPT value in future POSIX
> modes, not current ones.

So we should stop defining _XOPEN_CRYPT, but continue to declare crypt 
in <unistd.h> for __USE_MISC || __USE_XOPEN?  That would work for me.

I would like to see this committed this cycle, and will try to get this 
committed on Zack's behalf.

> The conform/ data is in any case meant to correspond to the standard
> versions in question (plus defect corrections from TCs etc., not plus
> feature changes from other revisions to the standard).  Intentionally
> unsupported features are listed in that data with appropriate XFAILs (see
> e.g. those for varargs.h in conform/Makefile).

I find these XFAILs fairly annoying, by the way.  Especially for things 
we simply cannot fix because we do not supply the header (<ndbm.h> comes 
to my mind).

Thanks,
Florian