This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 12/12] ldbl-128ibm-compat: Provide ieee128 symbols to narrow functions
On Wed, 20 Jun 2018, Tulio Magno Quites Machado Filho wrote:
> Add ieee128 aliases for faddl, fdivl, fmull, fsubl, daddl, ddivl, dmull, dsubl.
>
> 2018-06-19 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> * math/math-narrow.h [__HAVE_DISTINCT_FLOAT128 &&
> !__HAVE_FLOAT128_UNLIKE_LDBL] (libm_alias_float32_float128,
I don't think __HAVE_FLOAT128_UNLIKE_LDBL is logically right here. That's
about the current compilation, i.e. about whether these particular files
end up getting built with IEEE long double. I don't know what files in
the source tree might end up getting built with what long double setting,
but it shouldn't matter for these files whether they are built with IEEE
long double or not.
Your property is something different, "glibc has *ieee128 aliases for
_Float128 functions" (a property of the glibc configuration, not of the
current compilation, but a different property from
__HAVE_DISTINCT_FLOAT128). That suggests to me that either you need some
new macro tested by this file, or you need e.g.
math-narrow-alias-float128.h (included by math-narrow.h) which contains
these float128 alias macros and for which ldbl-128ibm-compat provides a
different version.
--
Joseph S. Myers
joseph@codesourcery.com