This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Assume that _IO_MTSAFE_IO is always defined in libio/stdfiles.c


* Andreas Schwab:

> On Jun 19 2018, Florian Weimer <fw@deneb.enyo.de> wrote:
>
>> * Andreas Schwab:
>>
>>> On Jun 19 2018, Florian Weimer <fw@deneb.enyo.de> wrote:
>>>
>>>> 	* libio/stdfiles.c (DEF_STDFILE): Assume that _IO_MTSAFE_IO is
>>>> 	always defined.
>>>
>>> Why only here?
>>
>> _IO_MTSAFE_IO has a bit of a checkered history.  Previous attempts at
>> removal failed when they encountered resistance in the form of parts
>> of the library that were *not* compiled with _IO_MTSAFE_IO.
>>
>> I need to change DEF_STDFILE to fix bug 23313.
>
> That bug isn't even referenced here.

Yes, it's an independent change.

Is the patch okay?  I can rework the upcoming patch to change the dead
code, but I'd prefer the cleanup.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]