This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4 1/2] Y2038: Add 64-bit time for all architectures


On Mon, 18 Jun 2018, Albert ARIBAUD (3ADEV) wrote:

>  sysdeps/x86_64/x32/bits/timesize.h  | 21 ++++++++++++++++
>  sysdeps/x86_64/x32/bits/timesizes.h | 32 +++++++++++++++++++++++++

(a) The different choice of time_t is specific to x32 *with the Linux 
kernel* and so should go in a Linux-specific sysdeps directory.

(b) For installed headers, a single header needs to handle all the 
different multilibs that can use a single compiler.  That is, just as 
sysdeps/unix/sysv/linux/x86/bits/typesizes.h handles all of i386, x86_64 
and x32, so these headers also need to be in 
sysdeps/unix/sysv/linux/x86/bits/ and contain conditionals for x32 
(defined __x86_64__ && defined __ILP32__) to determine the definitions to 
use.  You can't use e.g. x32-specific directories for installed headers, 
only for other implementation files.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]