This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/2] Y2038: make __tz_convert compatible with 64-bit-time
Hi Paul,
On Sat, 16 Jun 2018 07:23:29 -0700, Paul Eggert <eggert@cs.ucla.edu>
wrote :
> Albert ARIBAUD wrote:
> > if I remove the __ctime64 and __ctime64_r defines
> > and then build glibc for x86_64-linux-gnu, the linker stage fails due to
> > nis/nis_print.c lines 336 and 338 referring to an undefined ctime().
>
> How about if we fix nis/nis_print.c to use localtime_r and strftime instead of
> ctime? ctime is not thread-safe, and ctime_r is problematic due to the potential
> problem of overrunning its output buffer when given outlandish timestamps, so
> such a fix should be made regardless of the Y2038 changes.
I can do this in a further patch if/when that's agreed upon.
Cordialement,
Albert ARIBAUD
3ADEV