This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 07/13] nds32: Linux Syscall Interface


On Thu, 14 Jun 2018, Vincent Chen wrote:

> +/* This routine is jumped to by all the syscall handlers, to stash
> +   an error number into errno.  */
> +long int
> +__syscall_error (long int err)
> +{
> +  __set_errno (- err);

We use spaces around binary operators, but not after unary '-'.

> +         __set_errno (INTERNAL_SYSCALL_ERRNO (result_var, err));     \
> +			result_var = -1 ;			     \

No space before ';'.  The indentation of the second line here also seems 
way off.  Likewise again later in this file.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]