This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] scripts/update-abilist.sh: Accept empty list of files to patch
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: libc-alpha at sourceware dot org
- Date: Wed, 13 Jun 2018 22:41:27 +0200
- Subject: Re: [PATCH] scripts/update-abilist.sh: Accept empty list of files to patch
- References: <20180530130332.9E060415488E6@oldenburg.str.redhat.com>
* Florian Weimer:
> Commit b289cd9db8286fa6c670104dd5dfcfc68d5d00d6 (“Ignore absolute
> symbols in ABI tests.”) broke “make update-all-abi” because an empty
> list of files is now passed to scripts/update-abilist.sh.
>
> 2018-05-30 Florian Weimer <fweimer@redhat.com>
>
> * scripts/update-abilist.sh: Accept empty list of files to patch.
>
> diff --git a/scripts/update-abilist.sh b/scripts/update-abilist.sh
> index 68d469b3e5..28953bfe28 100644
> --- a/scripts/update-abilist.sh
> +++ b/scripts/update-abilist.sh
> @@ -20,9 +20,12 @@
> set -e
> export LC_ALL=C
>
> -if [ $# -lt 3 ]; then
> +if [ $# -lt 2 ]; then
> echo "usage: $0 OLD-FILE NEW-FILE FILES-TO-BE-PATCHED..." 1>&2
> exit 2
> +elif [ $# -eq 2 ]; then
> + echo "info: no files to patch" 1>&2
> + exit 0
> fi
>
> old_file="$1"
Ping?