This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3?] Avoid cancellable I/O primitives in ld.so.
- From: Samuel Thibault <samuel dot thibault at gnu dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org, schwab at suse dot de
- Date: Wed, 13 Jun 2018 20:30:43 +0200
- Subject: Re: [PATCH v3?] Avoid cancellable I/O primitives in ld.so.
- References: <20180607140252.16562-1-zackw@panix.com> <cc467fcc-fc99-dad4-15e1-86da3e5d45f3@linaro.org>
Hello,
Thanks for the Cc :)
Adhemerval Zanella, le lun. 11 juin 2018 23:12:46 -0300, a ecrit:
> > Right now, it appears that Hurd does not implement _nocancel I/O, so
> > sysdeps/generic/not-cancel.h will forward everything back to the
> > regular functions.
Yes, that part needs implementing.
> > This changed the names of some of the functions
> > that sysdeps/mach/hurd/dl-sysdep.c needs to interpose. I do not fully
> > understand how this works and I would appreciate specific review by
> > Hurd maintainers.
That looks good to me: dl-sysdep.c just needs to expose the symbols that
rtld uses.
> > I am getting test failures for cross compilation
> > to i686-gnu but I *think* this patch does not change the set of
> > failures. (Other than that, this patch shows no failures whatsoever
> > in a build-many-glibcs cycle.)
I have tried to build a glibc with the patch, programs start fine, so it
is good.
Thanks,
Samuel