This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 13 Jun 2018 14:08:16 +0000
- Subject: Re: [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert
- References: <20180613070019.4639-1-albert.aribaud@3adev.fr> <20180613095858.55d56502@athena>
On Wed, 13 Jun 2018, Albert ARIBAUD wrote:
> These patches have also been tested using build-many-glibcs.py, always
> for x86_64, aarch64, arm and powerpc compilers, and regularly for all
> compilers, and found to give the same results as those of the current
> glibc master above which the patches were created.
Since build-many-glibcs.py should give clean results everywhere except
i686-gnu, and since this patch adds Versions entries at a public ABI
version but has no *.abilist updates, I'm skeptical of the above
description of testing. You should have no ABI test failures before the
patch series, anywhere, whether in your normal ARM testing or with
build-many-glibcs.py, and without *.abilist updates you should be seeing
such failures after the patch series.
Any patch adding new ABIs at public versions always needs to include the
ABI baseline updates for *all* glibc configurations.
You should do full execution testing for at least one 64-bit
configuration, as well.
--
Joseph S. Myers
joseph@codesourcery.com