This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Y2038: add type __time64_t

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: "Albert ARIBAUD (3ADEV)" <albert dot aribaud at 3adev dot fr>, libc-alpha at sourceware dot org
Date: Wed, 13 Jun 2018 01:38:09 -0700
Subject: Re: [PATCH 1/2] Y2038: add type __time64_t
References: <20180613070019.4639-1-albert.aribaud@3adev.fr> <20180613070019.4639-2-albert.aribaud@3adev.fr>

Albert ARIBAUD (3ADEV) wrote:

-__STD_TYPE __TIME_T_TYPE __time_t;	/* Seconds since the Epoch.  */
+__STD_TYPE __TIME_T_TYPE __time_t;	/* Seconds since the Epoch, Y2038-unsafe.  */

This change to commentary is confusing, as __time_t is Y2038-safe on 64-bithosts. I suggest omitting the change, and changing the comment on the next lineto "Seconds since the Epoch (TIME_BITS==64)" (or whatever the name of that macrois).

Follow-Ups:
- Re: [PATCH 1/2] Y2038: add type __time64_t
  - From: Albert ARIBAUD

References:
- [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert
  - From: Albert ARIBAUD (3ADEV)
- [PATCH 1/2] Y2038: add type __time64_t
  - From: Albert ARIBAUD (3ADEV)

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]