This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PING: [PATCH] benchtests: Add -f/--functions argument

From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 12 Jun 2018 21:35:48 +0530
Subject: Re: PING: [PATCH] benchtests: Add -f/--functions argument
References: <CAMe9rOqid5ksKa=tt5fu43Oox5khKF=+ESPcb5XF+s_wxBEkhg@mail.gmail.com>

On 06/12/2018 07:59 PM, H.J. Lu wrote:

On Thu, May 24, 2018 at 10:40 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:

On x86-64, there may be multiple IFUNC implementations for a given
function.  But we may be only interested in a subset of them.  This
patch adds -f/--functions argument to compare a subset of IFUNC
implementations.

Any comments?


H.J.
---
         * benchtests/scripts/compare_strings.py (process_results): Add
         funcs argument.  Compare only functions which are selected.
         (main): Check if base function is among selected functions.
         Pass selected functions to process_results.
         (__main__): Add -f/--functions argument.


I rebased my patch against the current master.

Any comments, objections?

Thanks, looks OK to me. I kinda dislike the idea of 7 arguments toprocess_results but that probably is a separate cleanup.


Siddhesh

References:
- PING: [PATCH] benchtests: Add -f/--functions argument
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]