This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Makerules: pass CFLAGS when building .S files, BZ #23273
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fweimer at redhat dot com>, Sergei Trofimovich <slyich at gmail dot com>, libc-alpha at sourceware dot org
- Cc: Sergei Trofimovich <slyfox at gentoo dot org>
- Date: Mon, 11 Jun 2018 08:17:37 -0300
- Subject: Re: [PATCH] Makerules: pass CFLAGS when building .S files, BZ #23273
- References: <20180611102815.12982-1-slyich@gmail.com> <a763d070-cb2f-27d3-043d-1c7ecd0520df@redhat.com>
On 11/06/2018 07:46, Florian Weimer wrote:
> On 06/11/2018 12:28 PM, Sergei Trofimovich wrote:
>> When glibc is built on armv7 with CFLAGS="-pipe -march=armv7-a -O2 -mfpu=neon"
>> rtld fails to link due to missing memcpy symbol.
>>
>> This happens because .c files are built with -mfpu=neon flag but .S/.s files
>> are built without it. Among other things -mfpu=neon defines __ARM_NEON__.
>>
>> To fix this mismatch CFLAGS should be passed consistently to .c and .S files.
>
> Please check if you can fix this by putting the architecture selection flags into the CC and CXX variables when invoking configure.
That is the usual way build-many-glibcs.py does to check for different
variant and this is the way I used to check such flag combination when
I refactor arm ifunc. The armv7 configuration does build fine when
the options are used for CC and CXX.